Throw error when component is undefined or null (#2038) #2041
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
posva
requested changes
Feb 2, 2018
|
Oh sorry I missed that. Will try to work on that. |
|
Keep in mind you can run the tests locally too, it will save you some time 😄 |
|
Just now, I've tried to trace through what might be throwing error when it shouldn't. Then I found in You might want to review it again. Anyway thanks for the guide. |
posva
added
improvement
WIP
vinibrsl
suggested changes
Feb 7, 2019
| maps = createRouteMap([{ path: '/' }]) | ||
| expect(console.warn).toHaveBeenCalled() | ||
| }) | ||
|
|
There was a problem hiding this comment.
I would create an spec similar to this one, but to test that this is not affecting production env, with not.toHaveBeenCalled 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add assertion when a route component is null or undefined, a fix for issue #2038.
Really appreciate for a review.